test(datetime): cover invalid timestamp errors in nanos conversions#3651
Open
vishnuprakaz wants to merge 1 commit into
Open
test(datetime): cover invalid timestamp errors in nanos conversions#3651vishnuprakaz wants to merge 1 commit into
vishnuprakaz wants to merge 1 commit into
Conversation
ebyhr
approved these changes
Jul 14, 2026
|
|
||
|
|
||
| def test_timestamp_to_nanos_invalid_timestamp() -> None: | ||
| with pytest.raises(ValueError, match="Invalid timestamp without zone: invalid"): |
Member
There was a problem hiding this comment.
We could verify the entire message:
re.escape("Invalid timestamp without zone: invalid (must be ISO-8601)")|
|
||
|
|
||
| def test_timestamp_to_nanos_invalid_timestamp() -> None: | ||
| with pytest.raises(ValueError, match="Invalid timestamp without zone: invalid"): |
Member
There was a problem hiding this comment.
nit: We could verify the entire message:
re.escape("Invalid timestamp without zone: invalid (must be ISO-8601)")Same for test_timestamptz_to_nanos_invalid_timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow-up to #3505, addressing @ebyhr's suggestion to cover the untested error branches:
Invalid timestamp without zoneintimestamp_to_nanosInvalid timestamp with zoneintimestamptz_to_nanos.Are these changes tested?
Yes this PR is tests only.
Are there any user-facing changes?
No.